The invention discloses a preparation method of base metal carbon cladded nickel sulfide photocatalyst and an application thereof; the base metal carbon cladded nickel sulfide photocatalyst is prepared by taking nickel acetate and sulfur source as raw materials, and preparing nickel sulfide by hydrothermal reaction; taking glucose as the carbon source and performing the secondary hydrothermal reaction on glucose and nickel sulfide. The preparation method is simple, high-efficient, environment-friendly, controllable and low in cost, and others; the prepared base metal carbon cladded nickel sulfide photocatalyst is sea urchin type nano-material, and is significantly featured by high stability, big specific are, high catalyst activity and others.