A visor (10) includes a moulded polymeric core (20) having a plurality of channels (41) on at least one side (22) defined by a pair of spaced upstanding walls (40,42) with one of the walls (42) having a plurality of spaced notches (54) formed therein for receiving tabs (30) projecting outwardly from aligned upstanding walls (28) formed in the corresponding mating visor half (24). The tabs (30) extend into the corresponding slots (54) and a backing wall (40) prevents their removal. Visors embodying another aspect of the present invention integrally include a plurality of outwardly projecting pins (25) and corresponding mating recesses (26) formed around the periphery on opposite visor core halves for compressing the edges of upholstery material (16) and clamping them in a secure position as the visor halves (22,24) are brought together during manufacturing.