A carton for smoking articles has means for holding and/or extinguishing used such articles, which are capable of being handled in conventional handling machinery. In one embodiment, cigarettes (4) are preassembled in individual holding tubes (5) before assembly of the charge of cigarettes. The charge is then inserted into a pre-erected carton or other carton is erected around it. The articles may have portions (18, 19) of different diameters one being a tighter fit with a tubular holder (15) than the other, to ensure extinction, but not being engageable with the holder while the article is still full-length. The holder (15) may be lined (16) with heat-conductive or -absorbent material.