A machine for packing cigarettes in which packets, having one open end, are made by successively wrapping an inner layer of foil and an outer layer of paper round a former, transferring the open ended packets into a pocket on a conveyor, and then inserting a batch of twenty cigarettes into each packet. A plurality of packet-making devices, and batch-forming devices are provided, the conveyor being so positioned that each pocket first passes all the packet-making devices in succession and then all the batch-forming devices in succession.